On Wed, Apr 06, 2011 at 09:40:14PM +0300, Felipe Balbi wrote: > Hi Greg, > > On Wed, Apr 06, 2011 at 11:11:34AM -0700, Greg KH wrote: > > On Wed, Apr 06, 2011 at 11:14:28PM +0530, Jassi Brar wrote: > > > On Wed, Apr 6, 2011 at 3:12 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > > > CONFIG_USB is only for the host side, if we > > > > want to build a device-only kernel and our > > > > gadget Makefile is dependent on drivers/usb/Makefile > > > > we won't be able to have the driver unless we > > > > enable host side support. Fix it. > > > > > > I can't help but get heretic ideas in my mind - there should > > > be two separate and independent entries in make menuconfig > > > For USB Host and USB Gadget each. And 'while at it' we'd > > > better reorganise the files/directory structure as well :) > > > > We thought about that years ago, but decided not to do that, sorry. > > if you prefer, instead of making drivers/usb always enter on the > compilation process, I could have a patch such as: > > diff --git a/drivers/Makefile b/drivers/Makefile > index 3f135b6..3f13bf9 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -64,11 +64,10 @@ obj-$(CONFIG_ATA_OVER_ETH) += block/aoe/ > obj-$(CONFIG_PARIDE) += block/paride/ > obj-$(CONFIG_TC) += tc/ > obj-$(CONFIG_UWB) += uwb/ > -obj-$(CONFIG_USB_OTG_UTILS) += usb/otg/ > +obj-$(CONFIG_USB_OTG_UTILS) += usb/ > obj-$(CONFIG_USB) += usb/ > -obj-$(CONFIG_USB_MUSB_HDRC) += usb/musb/ > +obj-$(CONFIG_USB_GADGET) += usb/ > obj-$(CONFIG_PCI) += usb/ > -obj-$(CONFIG_USB_GADGET) += usb/gadget/ > obj-$(CONFIG_SERIO) += input/serio/ > obj-$(CONFIG_GAMEPORT) += input/gameport/ > obj-$(CONFIG_INPUT) += input/ > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > index 239f050..a7e259e 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -45,3 +45,8 @@ obj-$(CONFIG_EARLY_PRINTK_DBGP) += early/ > > obj-$(CONFIG_USB_ATM) += atm/ > obj-$(CONFIG_USB_SPEEDTOUCH) += atm/ > + > +obj-$(CONFIG_USB_OTG_UTILS) += otg/ > +obj-$(CONFIG_USB_GADGET) += gadget/ > + > +obj-$(CONFIG_USB_MUSB_HDRC) += musb/ > > if you prefer this one, I can send in a jiffy. That seems to make a bit more sense to me, how about you? If you agree, feel free to send it and I'll queue it up. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
