On Wed, Mar 30, 2011 at 08:01, Sergei Shtylyov wrote: > On 29-03-2011 20:33, Mike Frysinger wrote: >>>> + Â Â Â Â Â Â Â if (musb_channel->transmit&& Â*mode == 1) >>>> + Â Â Â Â Â Â Â Â Â Â Â *len = *len - (*len % *packet_sz); >>> >>> Â Parens not needed. And why not: >>> >>> Â Â Â Â*len -= *len % *packet_sz; >>> >>> We're coding in C, after all. :-) >> >> yes, but rather than force people to remember the more obscure >> operator precedence, Âjust about anyone can look at my version and >> instantly digest what it's doing. > > Â Hm? All precedences seems quite natural here -- "mod" has priority over > minus in math. i dont think that's a rule everyone gets ingrained in their math classes. certainly wasnt for me :p. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
