On Wed, Mar 30, 2011 at 02:44:52PM +0530, Praveena Nadahally wrote: > This patch enables USB Test Mode control > from a new "testmode" file in sysfs: > - write "-1" to this file to get some help > - write another value to select a test mode > - read this file to get current TM register value > > This control can be used in USB Host or Device mode. > This will be very useful in case of host mode. > > Signed-off-by: Gérald Baëza <gerald.baeza@xxxxxxxxxxxxxx> > Signed-off-by: Praveena Nadahally <praveen.nadahally@xxxxxxxxxxxxxx> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx> NAK. that's supposed to be done via host side. All you need to do is issue a correct control message. > diff --git a/drivers/usb/musb/musb_virthub.c b/drivers/usb/musb/musb_virthub.c > index 489104a..583bbec 100644 > --- a/drivers/usb/musb/musb_virthub.c > +++ b/drivers/usb/musb/musb_virthub.c > @@ -381,9 +381,6 @@ int musb_hub_control( > musb_port_suspend(musb, true); > break; > case USB_PORT_FEAT_TEST: > - if (unlikely(is_host_active(musb))) > - goto error; > - playing wrong!!!! -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
