Re: [PATCH] pl25a1_support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 30-03-2011 7:44, Simon Wood wrote:

Adds support for 'Windows Easy Transfer' cables based around the
Prolific PL-25A1 chip (includes Belkin F5U258&  F5U279)

Patch originally suggested by David Brownell here:
http://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg61926.html

Modified to work with latest kernel, tested with F5U279.

Signed-off-by: Simon Wood<simon@xxxxxxxxxxxxx>

[...]

diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c
index 08ad269..a20afac 100644
--- a/drivers/net/usb/plusb.c
+++ b/drivers/net/usb/plusb.c
[...]
@@ -89,13 +97,17 @@ static int pl_reset(struct usbnet *dev)
  	/* some units seem to need this reset, others reject it utterly.
  	 * FIXME be more like "naplink" or windows drivers.
  	 */
-	(void) pl_set_QuickLink_features(dev,
+	int     status;
+
+        status = pl_set_QuickLink_features(dev,

   This line is indented with spaces ISO tab.

+	if (status != 0 && netif_msg_probe(dev))
+		netif_dbg(dev, link, dev->net, "pl_reset --> %d\n", status);
 	return 0;
 }

Also, the above change doesn't seem to be related to the declared purpose of the patch, so seems to be a matter of another patch...

@@ -134,16 +153,16 @@ static struct usb_driver plusb_driver = {

  static int __init plusb_init(void)
  {
- 	return usb_register(&plusb_driver);
+	return usb_register(&plusb_driver);
  }
  module_init(plusb_init);

  static void __exit plusb_exit(void)
  {
- 	usb_deregister(&plusb_driver);
+	usb_deregister(&plusb_driver);
  }

   Likewise, the whitespace fixes should be a matgter of a separate patch...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux