On Mon, Mar 28, 2011 at 11:16:37PM +0100, Steven Hardy wrote: > + /* Set serial->private if not returning -ENODEV */ > + if ( retval != -ENODEV ) ^ ^ coding style > + usb_set_serial_data(serial, data); > return retval; > } the rest looks good to me. -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html