On Mon, Mar 28, 2011 at 05:57:21AM -0400, Mike Frysinger wrote: > On Mon, Mar 28, 2011 at 05:42, Felipe Balbi wrote: > > On Mon, Mar 28, 2011 at 05:26:46AM -0400, Mike Frysinger wrote: > >> >> any ideas on how to get this workaround merged ? another idea i had > >> >> was that we could add a hook to the top of dma_channel_program to let > >> >> targets muck with the arguments ... the Blackfin code would just need > >> >> to do something like this at the start of the func: > >> >> + if (musb_channel->transmit && channel->desired_mode == 1) > >> >> + len = len - (len % packet_sz); > >> > > >> > is that IP-related or Blackfin-only ? I mean, does this bug affects all > >> > MUSB of a particular RTL version or only the Blackfin ones ? > >> > >> our understanding of the issue is that it is Blackfin specific. seems > >> to be related to our internal bus/dma connections to the musb ip. > > > > ok. So we need a way to understand we need to apply that workaround only > > on blackfin. There we go with another blackfin-only driver flag... > > seems a shame to add a flag that will always evaluate to false for > non-Blackfin targets yet needs to be runtime checked for everyone ... I'm not keen in having ifdefs... Any other suggestions ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html