Re: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

(break your lines at 80-chars, I asked you to do this before)

On Mon, Mar 28, 2011 at 08:06:32AM +0000, kalle.jokiniemi@xxxxxxxxx wrote:
> Hi,
> 
>  > -----Original Message-----
>  > From: ext Keshava Munegowda [mailto:keshava_mgowda@xxxxxx]
>  > Sent: 28. maaliskuuta 2011 10:19
>  > To: Jokiniemi Kalle (Nokia-MS/Tampere); linux-usb@xxxxxxxxxxxxxxx; linux-
>  > omap@xxxxxxxxxxxxxxx; Felipe Balbi
>  > Cc: Krogerus Heikki (Nokia-MS/Helsinki); jhnikula@xxxxxxxxx; Kevin Hilman
>  > Subject: RE: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off
>  > 
>  > > +
>  > >  static struct platform_device rx51_charger_device = {
>  > > -	.name = "isp1704_charger",
>  > > +	.name	= "isp1704_charger",
>  > 
>  > Both are same; you don't need this change!
> 
> No, actually they are not same. I added tab instead of space to match
> indentation with the .dev member. This is the correct way IMHO.

Still, changing that indentation isn't part of $SUBJECT. You need to put
that in another patch.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux