RE: ehci scan_periodic loop time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please use Reply-to-All so that your messages get sent to the mailing 
list as well as to me.

On Fri, 25 Mar 2011, bradhuang wrote:

> Dears,
> 
> Could you kindly help to explain the meaning of your patch again?
> Since I do a test, it seems the watchdog reset issue has fixed.
> When I apply your patch, but there is a lack for scan_periodic(), in the
> line below:
> 
> 		// FIXME:  this assumes we won't get lapped when
> 		// latencies climb; that should be rare, but...
> 		// detect it, and just go all the way around.
> 		// FLR might help detect this case, so long as latencies
> 		// don't exceed periodic_size msec (default 1.024 sec).
> 
> 		// FIXME:  likewise assumes HC doesn't halt mid-scan
> 
> 		if (now_uframe == clock) {
> 			unsigned	now;
> 
> 			if (!HC_IS_RUNNING (ehci_to_hcd(ehci)->state)
> 					|| ehci->periodic_sched == 0)
> 				break;
> 			ehci->next_uframe = now_uframe;
> 			//now = ehci_readl(ehci, &ehci->regs->frame_index) %
> mod; //brad
> 			now = ehci_readl(ehci, &ehci->regs->frame_index) &
> (mod - 1); //brad
> 			if (now_uframe == now)
> 				break;
> 
> 			/* rescan the rest of this frame, then ... */
> 			clock = now;
> 			clock_frame = clock >> 3;
> 			if (ehci->clock_frame != clock_frame) {
> 				free_cached_lists(ehci);
> 				ehci->clock_frame = clock_frame;
> 			}
> 			++ehci->periodic_stamp; ==============> I do not
> patch this line
> 		} else {
> 			now_uframe++;
> 			//now_uframe %= mod;//brad
> 			now_uframe &= mod - 1;
> 		}

Where is the problem?  In the current version of the kernel,
ehci->periodic_stamp has been removed completely.

What version of the kernel are you using?  Can you try using 2.6.38?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux