On Fri, 25 Mar 2011 09:48:12 +0100, Sistemas Neurowork
<sistemas@xxxxxxxxxxxxx> wrote:
Greetings,
this patch fix some coding style errors.
Regards,
Alberto Ortega Llamas
sistemas@xxxxxxxxxxxxx
T: (+34) 916 851 242
Visit Neurowork: http://www.neurowork.net/
Blog: http://www.neurowork.net/blog
Twitter: http://www.twitter.com/Neurowork
We probably don't need all of that in a commit message. Just a
description.
Again, try using git send-email.
@@ -229,17 +229,17 @@ EXPORT_SYMBOL_GPL(usb_stor_post_reset);
void fill_inquiry_response(struct us_data *us, unsigned char *data,
unsigned int data_len)
{
- if (data_len<36) // You lose.
+ if (data_len < 36) /* You lose. */
return;
memset(data+8, ' ', 28);
- if(data[0]&0x20) { /* USB device currently not connected. Return
+ if (data[0]&0x20) { /* USB device currently not connected. Return
peripheral qualifier 001b ("...however, the
physical device is not currently connected
to this logical unit") and leave vendor and
product identification empty. ("If the target
does store some of the INQUIRY data on the
- device, it may return zeros or ASCII spaces
+ device, it may return zeros or ASCII spaces
(20h) in those fields until the data is
available from the device."). */
If you touch that, why not make the comment more like coding style
recommends?
Push it down a line so it starts on its own line and make it proper
multiline
comment.
@@ -295,7 +295,7 @@ static int usb_stor_control_thread(void * __us)
scsi_unlock(host);
- /* reject the command if the direction indicator
+ /* reject the command if the direction indicator
* is UNKNOWN
*/
Same here.
@@ -319,7 +319,7 @@ static int usb_stor_control_thread(void * __us)
us->srb->result = DID_BAD_TARGET << 16;
}
- /* Handle those devices which need us to fake
+ /* Handle those devices which need us to fake
* their inquiry data */
And here.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
