RE: [PATCH 0/2] USB: twl4030-usb: fix isp1707 xceiver powering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

 > -----Original Message-----
 > From: Heikki Krogerus [mailto:heikki.krogerus@xxxxxxxxx]
 > Sent: 22. maaliskuuta 2011 11:46
 > To: Jokiniemi Kalle (Nokia-MS/Tampere)
 > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; balbi@xxxxxx;
 > tony@xxxxxxxxxxx; jhnikula@xxxxxxxxx; Koskinen Ilkka (Nokia-MS/Tampere)
 > Subject: Re: [PATCH 0/2] USB: twl4030-usb: fix isp1707 xceiver powering
 > 
 > Hi Kalle,
 > 
 > Missed the cover letter so I already commented the patches.
 > 
 > On Mon, Mar 21, 2011 at 03:50:18PM +0200, Kalle Jokiniemi wrote:
 > > These two patches introduce phy_power calls form board files
 > > to twl4030-usb. This fixes a problem in Nokia N900, where the
 > > ISP1707 serial tranceiver did not get disabled during phy
 > > power down.
 > >
 > > Based on patches used on n900 maemo kernel, mainly from Heikki
 > > Krogerus. Comments&testing appreciated.
 > >
 > > Basic test done on MeeGo + linux usb that the ISP powering
 > > happens correctly. Also simple data transfer tests done with
 > > backported patches on MeeGo n900 kernel.
 > >
 > > Cross posting to linux-omap, but I propose that we'd push these
 > > to linux-usb. Patches based on linux-usb master.
 > >
 > > Kalle Jokiniemi (2):
 > >   USB: twl4030-usb: do board specific phy_power up/down
 > >   OMAP3: rx51: specify phy_power for usb tranceiver
 > >
 > >  arch/arm/mach-omap2/board-rx51-peripherals.c |   32
 > ++++++++++++++++++++++++++
 > >  drivers/usb/otg/twl4030-usb.c                |    9 ++++++-
 > >  2 files changed, 40 insertions(+), 1 deletions(-)
 > 
 > I do like the idea of getting the support for power down mode of
 > isp1707 in RX51 but...
 > 
 > If I understood correctly, meego has the isp1704_charger driver from
 > mainline, so we don't need to involve twl4030-usb when powering the
 > isp1707 like we did in maemo kernel.

Thanks for all the comments. I'll rework the driver to use the isp charger driver instead.

- Kalle



 > 
 > --
 > heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux