RE: [PATCH 2/2] OMAP3: rx51: specify phy_power for usb tranceiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

 > -----Original Message-----
 > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
 > owner@xxxxxxxxxxxxxxx] On Behalf Of ext Sergei Shtylyov
 > Sent: 21. maaliskuuta 2011 16:29
 > To: Jokiniemi Kalle (Nokia-MS/Tampere)
 > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; balbi@xxxxxx;
 > tony@xxxxxxxxxxx; Krogerus Heikki (Nokia-MS/Helsinki);
 > jhnikula@xxxxxxxxx; Koskinen Ilkka (Nokia-MS/Tampere)
 > Subject: Re: [PATCH 2/2] OMAP3: rx51: specify phy_power for usb tranceiver
 > 
 > Hello.
 > 
 > Kalle Jokiniemi wrote:
 > 
 > > This patch allows the ISP1707 USB tranceiver on Nokia
 > > N900 to be disabled when usb cable is disconnected.
 > > This saves approximately 14mA of battery current.
 > 
 > > Patch based on work done by Heikki Krogerus on N900
 > > maemo kernel.
 > 
 > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@xxxxxxxxx>
 > > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxx>
 > > ---
 > >  arch/arm/mach-omap2/board-rx51-peripherals.c |   32
 > ++++++++++++++++++++++++++
 > >  1 files changed, 32 insertions(+), 0 deletions(-)
 > 
 > > diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c
 > b/arch/arm/mach-omap2/board-rx51-peripherals.c
 > > index e75e240..9dd22bc 100644
 > > --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
 > > +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
 > [...]
 > > @@ -534,8 +537,36 @@ static struct twl4030_gpio_platform_data
 > rx51_gpio_data = {
 > >  	.setup			= rx51_twlgpio_setup,
 > >  };
 > >
 > > +static void __init rx51_xceiv_init(void)
 > > +{
 > > +	if (gpio_request(RX51_USB_TRANSCEIVER_RST_GPIO, NULL) < 0)
 > > +		BUG();
 > 
 >     Why not:
 > 
 > 	BUG_ON(gpio_request(RX51_USB_TRANSCEIVER_RST_GPIO, NULL) <
 > 0);

Makes sense, will change that. Thanks for the comments.

- Kalle

 > 
 > WBR, Sergei
 > 
 > --
 > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
 > the body of a message to majordomo@xxxxxxxxxxxxxxx
 > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux