Re: [PATCH 1/2]Merge staging/keucr SD card reader codes to driver/usb/storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/2/22 Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>:
> On Tue, 22 Feb 2011, huajun li wrote:
>
>>    1. driver/staging/keucr uses many duplicate codes of usb-storage,
>> in this patch, merge SD card reader code into drivers/usb/storage/,
>> this is the first step. However, SM, MS and other card driver codes
>> are not merged to usb-storage.
>>    2. Move firmware of ENE UB6250 SD card reader to
>> firmware/ene-ub6250, please refer to the second patch for more
>> details.
>>    The patch is tested on Acer Aspire one NAV50.
>>
>> ---
>>  drivers/usb/storage/Kconfig              |   14 +
>>  drivers/usb/storage/Makefile             |    2 +
>>  drivers/usb/storage/ene_ub6250.c         |  788 ++++++++++++++++++++++++++++++
>>  drivers/usb/storage/unusual_ene_ub6250.h |   26 +
>>  4 files changed, 830 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/usb/storage/ene_ub6250.c
>>  create mode 100644 drivers/usb/storage/unusual_ene_ub6250.h
>
> You also have to modify usual_tables.c.
>
Hi Alan,
Thanks for your reminder, I will update it, thanks.

>> diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
>> index 49a489e..70a05f6 100644
>> --- a/drivers/usb/storage/Kconfig
>> +++ b/drivers/usb/storage/Kconfig
>> @@ -198,3 +198,17 @@ config USB_LIBUSUAL
>>               options libusual bias="ub"
>>
>>         If unsure, say N.
>> +
>> +config USB_STORAGE_ENE_UB6250
>> +     tristate "USB ENE card reader support"
>> +     depends on USB && SCSI
>> +     ---help---
>> +       Say Y here if you wish to control a ENE Card reader.
>> +
>> +       This option depends on 'SCSI' support being enabled, but you
>> +       probably also need 'SCSI device support: SCSI disk support'
>> +       (BLK_DEV_SD) for most USB storage devices.
>> +
>> +       To compile this driver as a module, choose M here: the
>> +       module will be called ene_ub6250.
>
> Why isn't it called ums-eneub6250, or even ums-eneub, like all the
> other subdriver modules?
>
Good suggestion, thanks.

> Alan Stern
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux