On Thu, Feb 24, 2011 at 02:21:37PM -0800, Greg KH wrote:
> On Thu, Feb 24, 2011 at 11:17:47PM +0100, Josua Dietze wrote:
> > Am 24.02.2011 22:56, schrieb Greg KH:
> > >Ok, but as this is just a fork of an existing in-kernel driver, we need
> > >a patch, sent to us in the format described in
> > >Documentation/SubmittingPatches, for us to be able to accept it.
> >
> > AFAIK this is far from being ready for inclusion in the kernel.
>
> Why? How many changes are there to the existing driver that are really
> needed for this hardware?
In looking at the driver, I see only 1 line being added:
+ { USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /* Samsung GT-B3730 LTE USB modem.*/
That doesn't warrent a whole new stand-alone copy of the driver, not to
mention the fact that the version copied is older than the in-kernel
driver so it misses a number of needed fixes and device ids that have
happened since it was copied.
Also, the line above isn't even _needed_ for people to test this device,
they can just echo the device id to the "new_id" file for the driver and
get it to bind properly, no driver changes are needed at all.
too strange...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
