On Tue, Feb 22, 2011 at 05:59:52PM +0800, huajun li wrote: > 1. driver/staging/keucr uses many duplicate codes of usb-storage, > in this patch, merge SD card reader code into drivers/usb/storage/, > this is the first step. However, SM, MS and other card driver codes > are not merged to usb-storage. > 2. Move firmware of ENE UB6250 SD card reader to > firmware/ene-ub6250, please refer to the second patch for more > details. > The patch is tested on Acer Aspire one NAV50. > > --- I need a "Signed-off-by:" line in order to be able to accept this patch. I also don't understand, is this the keucr code moving to the drivers/usb/storage/ directory? If so, why not remove the keucr code in th same patch as we don't want two copies of the driver in the kernel at the same time. Also, does this remove the duplication of the drivers/usb/storage code that is in the existing keucr driver? At first glance, it doesn't look like it to me. Also, please always run your patches through the scripts/checkpatch.pl script before sending them, and fix the errors and warnings it finds. Care to try again? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
