On Thu, Feb 17, 2011 at 2:31 PM, Greg KH <gregkh@xxxxxxx> wrote: > On Thu, Feb 17, 2011 at 02:15:01PM -0800, Benoit Goby wrote: >> diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig >> index 9ffc823..02952c4 100644 >> --- a/drivers/usb/otg/Kconfig >> +++ b/drivers/usb/otg/Kconfig >> @@ -49,6 +49,13 @@ config USB_ULPI >> Enable this to support ULPI connected USB OTG transceivers which >> are likely found on embedded boards. >> >> +config USB_ULPI_VIEWPORT >> + bool "ULPI Viewport Access Operations" >> + depends on USB_ULPI >> + help >> + Provides read/write operations to the ULPI phy register set for >> + controllers with a viewport register (e.g. Chipidea/ARC controllers). > > Why would this be a Kconfig option? Why not just always have this > option enabled if USB_ULPI is enabled? How will someone know to enable > this or not? > This is not part of the ulpi spec. You may have a ulpi phy but have a controller that does not have a viewport register. I will remove the Kconfig option. Drivers that depend on it should select it, it does not need to be user configurable. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
