Re: [PATCH 04/21] usb: musb: disable double buffering when it's broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 11, 2011 at 12:26:47AM +0100, Johan Hovold wrote:
> On Thu, Feb 10, 2011 at 12:15:59PM -0800, Greg Kroah-Hartman wrote:
> > From: Felipe Balbi <balbi@xxxxxx>
> > 
> > We know that blackfin doesn't support double
> > buffering feature as of today. So we add a
> > flag set by musb_platform_init() to forcefully
> > disable that feature.
> > 
> > Such flag is created and marked as deprecated
> > to force us to find a solution for the missing
> > double buffering support on blackfin.
> 
> This patch breaks builds with CONFIG_USB_GADGET_MUSB_HDRC unset: 
> 
> 
>   CC      drivers/usb/musb/musb_host.o
> drivers/usb/musb/musb_host.c: In function âmusb_rx_reinitâ:
> drivers/usb/musb/musb_host.c:612: error: âstruct musbâ has no member named âdouble_buffer_not_okâ
> drivers/usb/musb/musb_host.c: In function âmusb_ep_programâ:
> drivers/usb/musb/musb_host.c:787: error: âstruct musbâ has no member named âdouble_buffer_not_okâ
> 
> 
> as the double_buffer_not_ok flag is compiled out of struct musb in this
> case. Moving the declaration out of the ifdef fixes my build.

Ick.  Felipe, care to send a patch fixing this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux