On Thu, Feb 10, 2011 at 02:17:49PM -0800, Luben Tuikov wrote: > --- On Thu, 2/10/11, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote: > > > --- On Wed, 2/9/11, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> > > wrote: > > Speaking of this "club"... When will someone review my "uasp.c" driver? It > didn't even get a a review. Your patches did get a review, and while they had technical merit, you derailed the discussion and ostracized everyone involved. Until we can have a focused technical conversation that doesn't devolve into personal attacks, it will be difficult to get anything done. > Will it make it into Linux? Or will you and > Willy, both from Intel, insist on keeping uas.c instead? There were several people besides Matthew and I that agreed that current UAS driver in the kernel needs to be fixed, and that having two drivers leads to confusion with users. There were also people that agreed that your driver had technical merit, and that the UAS driver in kernel needed work. I don't think a whole-sale replacement is going to be easy to push for on your side. If you do care about UAS and getting a good Linux driver, you should submit a longer patchset to the current driver to fix it. The patchset should first fix any real technical errors (like the kzalloc fix you found), then have separate patches to clean up the code. No one has time to read one giant patch, either for adding your new driver, or for cleaning up the current driver. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
