Hi Alan, On Thu, Feb 10, 2011 at 10:11:46AM -0500, Alan Stern wrote: > On Thu, 10 Feb 2011, Felipe Balbi wrote: > > > checkpatch.pl prefers us to use __packed instead > > of the more lengthy __attribute__ ((packed)), so > > a simple search and replace fixed all occurrences > > on all USB headers. > > > > This patch was conceived with the following: > > > > $ for i in $(git grep -e "__attribute__.((packed))" \ > > include/linux/usb/ | cut -d: -f1 | uniq); \ > > do sed -i 's/__attribute__ ((packed))/__packed/g' \ > > $i; done > > > > It fixes checkpatch.pl warnings such as: > > > > WARNING: __packed is preferred over __attribute__((packed)) > > #838: FILE: linux/usb/ch9.h:838: > > +} __attribute__((packed)); > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > Relevant to this patch... It was pointed out recently that unnecessary > __packed attributes can cause problems for memory-mapped I/O. In > particular, the attributes in include/linux/usb/ehci_def.h should be > removed. should it be a patch before this one, then ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
