> -----Original Message----- > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > Sent: Thursday, February 10, 2011 9:44 AM > To: Xu, Andiry > Cc: Sergei Shtylyov; Greg Kroah-Hartman; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 07/42] xHCI: remove redundant parameter in > giveback_first_trb() > > On Wed, Feb 09, 2011 at 10:42:50AM +0800, Xu, Andiry wrote: > > > -----Original Message----- > > > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > > > Sent: Wednesday, February 09, 2011 1:22 AM > > > To: Sergei Shtylyov > > > Cc: Greg Kroah-Hartman; linux-usb@xxxxxxxxxxxxxxx; Xu, Andiry > > > Subject: Re: [PATCH 07/42] xHCI: remove redundant parameter in > > > giveback_first_trb() > > > > > > On Thu, Feb 03, 2011 at 05:03:46PM +0300, Sergei Shtylyov wrote: > > > > Hello. > > > > > > > > On 31-01-2011 21:12, Greg Kroah-Hartman wrote: > > > > > > > > >From: Andiry Xu<andiry.xu@xxxxxxx> > > > > > > > > >Parameter *td is not used in giveback_first_trb(). Remove it. > > > > > > > > So the description finally didn't get updated. Very nice. :-/ > > > > > > Yes, I was trying to send this patchset off before going to a > > > conference, and didn't have time to do any back and forth with the > > patch > > > author to get it updated. Sorry about that, but it's better that the > > > fixes get in than languish in my queue waiting to be absolutely > > perfect. > > > > > > > Hi Sarah, > > > > I've resent the patch with description updated on 01/11/11. Did you > > receive that? > > Sorry, I might have missed it, or I might have screwed up in my git > patchset creation. I need to work on my patch management flow. > > > And I'm curious about the feedback of another patch > > "prolong host controller halt time limit" sent on 01/06/11... > > I'll take a look at that. I'm not very happy about it, since the host > controller has to be halted and reset during bootup. Are you sure > that's the very minimum time necessary? > 16ms is the maximum halt time limit, not the very minimum time necessary. From the implementation of handshake(), the function will return as soon as the HC is halted, so it will take less than 16ms. If the host controller can halt in less than 2ms, then extend the time limit to 16ms has no side effect. > > Also, can you help ack the AMD PLL quirk moving patch 2? Alan has acked > > the 1st patch. I'll resend the patchset based on the latest linux-next > > tree. > > I need to test that on my hardware before I sign off on that, and I'm > swimming in emails since I just got back from vacation on Tuesday. I > will try to get to it. > OK. The patch has no effect on non-AMD/ATI platforms. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
