On Tue, Jan 04, 2011 at 12:47:03PM +0100, Mian Yousaf Kaukab wrote:
> Gadget MUSB driver handles dma mappings in musb_gadget_queue(). Where as it is
> possible for dma code to reject the usb request later at ->channel_program()
> called from txstate()/rxstate()
>
> For example ->channel_program in tusb6010_omap.c:
>
> static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz,
> u8 rndis_mode, dma_addr_t dma_addr, u32 len)
> {
> ...
> if (unlikely(dma_addr & 0x1) || (len < 32) || (len > packet_sz))
> return false;
> ...
> if (dma_addr & 0x2)
> return false;
> ...
> }
>
> In this case, usb request will be handled in PIO mode which renders dma mapping
> operations unnecessary.
>
> This patch adds an api to allow dma code to indicate incompatibility with usb
> request. Gadget musb driver call this api, if available, before dma mappings to
> avoid any unnecessary mapping operations.
>
> Signed-off-by: Mian Yousaf Kaukab <mian.yousaf.kaukab@xxxxxxxxxxxxxx>
applied, thanks
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
