> -----Original Message----- > From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, January 14, 2011 11:31 PM > To: Xu, Andiry > Cc: gregkh@xxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > dbrownell@xxxxxxxxxxxxxxxxxxxxx; sarah.a.sharp@xxxxxxxxxxxxxxx; He, Alex > Subject: Re: [PATCH v2 1/2] USB host: Move AMD PLL quirk to pci-quirks.c > > On Fri, 14 Jan 2011, Andiry Xu wrote: > > > This patch move the AMD PLL quirk code in OHCI/EHCI driver to pci- > quirks.c, > > and export the functions to be used by xHCI driver later. > > ... > > > diff --git a/drivers/usb/host/pci-quirks.h b/drivers/usb/host/pci- > quirks.h > > index 1564edf..d2f4d44 100644 > > --- a/drivers/usb/host/pci-quirks.h > > +++ b/drivers/usb/host/pci-quirks.h > > @@ -3,5 +3,8 @@ > > > > void uhci_reset_hc(struct pci_dev *pdev, unsigned long base); > > int uhci_check_and_reset_hc(struct pci_dev *pdev, unsigned long base); > > +int usb_amd_find_chipset_info(void); > > +void usb_amd_quirk_pll(int disable); > > +void usb_amd_dev_put(void); > > > > #endif /* __LINUX_USB_PCI_QUIRKS_H */ > > Suggestion for minor improvement: Create separate functions > usb_amd_quirk_pll_enable() and usb_amd_quirk_pll_disable() instead of > #defining the arguments in every HCD. > > Also, what will happen if you have an AMD chipset with this PLL quirk > but you're using a USB host controller on an add-on PCI card? > After consideration, I think we will still probe only when the host controller is from AMD/ATI. Using a PCIE add-on USB host on an AMD/ATI platform with quirk and trigger this issue is a seldom case and normally it's not our responsibility. On the other hand, probing on all the platforms will cause unnecessary cost to most platforms on the market. We'll prefer that most non-AMD users do not need to spend this extra cost during host controller initialization. It's better for the majority. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
