On Fri, 14 Jan 2011, Andiry Xu wrote: > This patch move the AMD PLL quirk code in OHCI/EHCI driver to pci-quirks.c, > and export the functions to be used by xHCI driver later. ... > diff --git a/drivers/usb/host/pci-quirks.h b/drivers/usb/host/pci-quirks.h > index 1564edf..d2f4d44 100644 > --- a/drivers/usb/host/pci-quirks.h > +++ b/drivers/usb/host/pci-quirks.h > @@ -3,5 +3,8 @@ > > void uhci_reset_hc(struct pci_dev *pdev, unsigned long base); > int uhci_check_and_reset_hc(struct pci_dev *pdev, unsigned long base); > +int usb_amd_find_chipset_info(void); > +void usb_amd_quirk_pll(int disable); > +void usb_amd_dev_put(void); > > #endif /* __LINUX_USB_PCI_QUIRKS_H */ Suggestion for minor improvement: Create separate functions usb_amd_quirk_pll_enable() and usb_amd_quirk_pll_disable() instead of #defining the arguments in every HCD. Also, what will happen if you have an AMD chipset with this PLL quirk but you're using a USB host controller on an add-on PCI card? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
