Hello. Ming Lei wrote:
From: Ming Lei <tom.leiming@xxxxxxxxx> In fact, for tusb, musb_ep_select and MUSB_EP_OFFSET are same with that for indexed mapping, so merge the two cases to simplify definition of the two helpers. Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
[...]
diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h index edc0cca..3321bae 100644 --- a/drivers/usb/musb/musb_regs.h +++ b/drivers/usb/musb/musb_regs.h @@ -292,9 +292,6 @@ #define MUSB_FLAT_OFFSET(_epnum, _offset) \ (0x100 + (0x10*(_epnum)) + (_offset)) -/* TUSB6010 EP0 configuration register is special */
Hm, not sure if it's worth dropping this comment...
I think it is worth, please see the commit log.
Tusb takes indexed mapping about musb_ep_select and MUSB_EP_OFFSET, so it should not be special, should it?
One register, TUSB_EP0_CONF is special. "tusb6010.h" is later included because of it. Also, see the code in musb_core.c.
thanks,
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
