Hi, 2010/12/21 Sergei Shtylyov <sshtylyov@xxxxxxxxxx>: >> + if (musb->ops->flags & MUSB_GLUE_DMA_INVENTRA) >> + return "musb->dma"; > > '>' is not needed here. Good catch, thanks. 2010/12/22 Felipe Balbi <balbi@xxxxxx>: > Hi, > > On Wed, Dec 22, 2010 at 12:14:49AM +0800, tom.leiming@xxxxxxxxx wrote: >> >> + if (musb->ops->flags & MUSB_GLUE_DMA_INVENTRA) >> + return "musb->dma"; >> + else if (musb->ops->flags & MUSB_GLUE_DMA_CPPI) >> + return "cppi-dma"; >> + else if (musb->ops->flags & MUSB_GLUE_DMA_TUSB) >> + return "tusb-omap-dma"; > > let's make this a little more standard: > > all dma engines will be called dma-<name> so here you would have > something like: > > return "dma-inventra" > return "dma-cppi3" > return "dma-omap" Good idea, will do it in v2, :-) thanks, -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
