Re: [PATCH v3 0/4] USB: gadget: updating CI13xxx driver to work with g_ether

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On 12/15/2010 1:22 PM, Artem Leonenko wrote:
> Changes from v2:
> 	- fixed no_interrupt handling
> 	- fixed incorrent PAGE_SIZE usage
> 
> The CI13XXX driver has few issues that blocks g_ether gadget.
> 
> They are:
> 	- broken probe code if g_ether is compiled into the kernel
> 	- partially broken code for handling request queues with
> 	two or more elements
> 	- incorrect interpretation if request->no_interrupt field
> 	- wrong assumption that all platforms with all configurations
> 	have PAGE_SIZE = 4096.
> 
> The fixes were successfully tested on MIPS based SoC with 4KEc core and
> CI13XXX USB IP core.
> 
> Artem Leonenko (4):
>   USB: gadget: ci13xxx: fix probing of compiled-in gadget drivers
>   USB: gadget: update ci13xxx to work with g_ether
>   USB: gadget: ci13xxx: fix complete() callback for no_interrupt rq's
>   USB: gadget: ci13xxx: don't assume that PAGE_SIZE is 4096
> 
>  drivers/usb/gadget/ci13xxx_udc.c |   37 ++++++++++++++++++++-----------------
>  drivers/usb/gadget/ci13xxx_udc.h |    1 +
>  2 files changed, 21 insertions(+), 17 deletions(-)
> 
g_ether gadget (Any gadget, which queue requests in their ep request
completion handler) does not work without these patches. I have tested
the above patches on MSM and they work fine. I am working on improving
ep queue algorithm and making changes on top of these patches hoping
that you would accept these patches.

Thanks,
Pavan

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux