On 12/16/2010 6:37 PM, Felipe Balbi wrote: > On Thu, Dec 16, 2010 at 03:39:35PM +0300, Sergei Shtylyov wrote: >> Hello. >> >> On 16-12-2010 14:09, Pavankumar Kondeti wrote: >> >>> Some USB controllers have common resources (IRQ, register address >>> space) for Host, Peripheral and OTG. So HCD is added only before >>> entering into Host mode. Root hub initialization is done in >>> different steps to decrease boot up time. But this makes B-device >>> difficult to meet HNP timings. Hence eliminate delays involved in >>> root hub initialization for B-host. >> >>> This patch also marks hnp_supported flag TRUE for B-host while >>> registering the bus. >> >>> Change-Id: I821775e8c90bd71a7abbe17176f189664a1841e1 >>> Signed-off-by: Pavankumar Kondeti<pkondeti@xxxxxxxxxxxxxx> >> [...] >> >>> index ac79fd5..2df61ba 100644 >>> --- a/drivers/usb/core/hub.c >>> +++ b/drivers/usb/core/hub.c >>> @@ -680,6 +680,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type) >>> int status; >>> bool need_debounce_delay = false; >>> unsigned delay; >>> + bool hnp_in_progress = hdev->bus->is_b_host&& (type == HUB_INIT); >> >> Parens here are not necessary. > > there's also a missing space before && > There is one. Please see my original patch. I am not sure why it is missing in Sergei's reply. Thanks, Pavan -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
