Re: [RFC 3/5] USB: gadget: OTG supplement revision 2.0 updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/15/2010 5:48 PM, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Dec 15, 2010 at 04:44:12PM +0530, Pavankumar Kondeti wrote:
>> @@ -1047,9 +1065,10 @@ composite_unbind(struct usb_gadget *gadget)
>> 		kfree(cdev->req->buf);
>> 		usb_ep_free_request(gadget->ep0, cdev->req);
>> 	}
>> +	device_remove_file(&gadget->dev, &dev_attr_host_request);
>> +	device_remove_file(&gadget->dev, &dev_attr_suspended);
>> 	kfree(cdev);
>> 	set_gadget_data(gadget, NULL);
>> -	device_remove_file(&gadget->dev, &dev_attr_suspended);
> 
> this looks like something that shouldn't be part of this patch ?!?
> 
Yeah. I will send another patch for removing suspended sysfs file
before freeing the cdev.

Thanks,
Pavan

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux