Hi, I've looked at the patches but your email states there are 10 patches, I can't see #1 and #10, only 2- 8 ?? It doesn't look like you have resolved the lockdep issues we have been seeing, please get in contact as it would be good to discuss our issues with this driver ( and our distain for Synopsis ;-) ). Cheers Neil On Mon, Dec 13, 2010 at 3:48 PM, Neil Jones <neiljay@xxxxxxxxx> wrote: > Hi, > > We are currently using the latest version of this Synopsis IP in some > of our customers SoC's. > > The latest hardware adds a new DMA mode which is less Interrupt > intensive as well as a few other features. > > I have spent (and im still spending) a long time fixing up this driver > to be linux standards compliant with the intention of pushing it > upstream once complete, its still not ready yet. > > One of the major issues we had is the driver isn't SMP safe, I've not > had chance to review your patches yet but have your run the driver > with lock checking turned on ? > > Would it be possible to get the changes for the latest version of the > IP merged into this driver, I can supply my current version as a > reference. > > In my driver : > > Currently host support is working well and i've tested it with > multiple devices and done the test outlined on > http://www.linux-usb.org/usbtest/, the driver passed checkpatches and > runs with lockdeps on and on a SMP system, Im still working on the > device mode (PCD) part of the driver generally it works, but im still > getting the odd lock dep warning and a panic on un-loading of certain > gadget kernel modules. The only issue with our driver is I have not > converted all the bitfield usage to macros so it might make diffing a > pain. > > Cheers > > Neil > > On Fri, Dec 10, 2010 at 10:44 PM, Greg KH <greg@xxxxxxxxx> wrote: >> On Wed, Dec 08, 2010 at 04:28:59PM -0800, tmarri@xxxxxxx wrote: >>> From: Tirumala Marri <tmarri@xxxxxxx> >>> >>> v6: >>> Â1. Replaced register definitions and bit fields with macros. >>> Â2. Replace printks with dev_dbg or dev_err functions. >>> Â3. Cleanup some assignments. >>> Â4. Remove chip specific selections in Kconfig file. >> >> There are still a lot of checkpatch errors and warnings in these >> patches. ÂPatch 1-8 has: >> Â Â Â Âtotal: 64 errors, 126 warnings, 13905 lines checked >> >> Care to fix all of these up in your next submission? ÂI can't take these >> as-is, sorry. >> >> And, if you haven't run checkpatch.pl before, odds are you haven't run >> 'sparse'. ÂPlease run that as well and resolve the issues it finds. >> >> thanks, >> >> greg k-h >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html >> > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
