Re: [PATCH v3 3/4] USB: gadget: ci13xxx: fix complete() callback for no_interrupt rq's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Artem,

On 12/15/2010 1:16 PM, Artem Leonenko wrote:
> CI13xxx UDC driver doesn't call complete() callback for requests
> with flag no_interrupt set. Thus gadget drivers (like g_ether) are
> never notifed about successfully (or not) transmitted requests. As
> a result in case of g_ether and queued request with no_interrupt=1
> fields g_ether is never notifed about sent packets and TX stalls.
> 
> Solution: treat no_interrupt flag like all other UDC drivers do and
> call complete() callback for all requests.
> 
> Signed-off-by: Artem Leonenko <tikkeri@xxxxxxxxx>
> ---
>  drivers/usb/gadget/ci13xxx_udc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Thanks for submitting this patch. ping (-s option with 4096 bytes) fails
after 4 trips with g_ether without this patch. verified on MSM SoC.

Thanks,
Pavan
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux