Hi Felipe,
2010/12/13 Felipe Balbi <balbi@xxxxxx>:
> Hi,
>
> On Mon, Dec 13, 2010 at 08:11:41PM +0800, Ming Lei wrote:
>>
>> In fact, we can think glue device as specific device and musb device
>> (musb_hdrc) as more generic device, so glue driver should focus on
>> specific
>> hardware details and musb hdrc should be more generic to handle all
>> standard things.
>
> exactly, and that's why we pass function pointers of our hardware
> specific implementatations to the more generic musb_hdrc.
>
>> It is very reasonable that specific drivers depends on more generic
>> drivers,
>> for example, ehci/ohci/uhci drivers depend on usbcore.
>
> but ehci-omap doesn't depend on ehci, it sets things up for ehci.
IMHO, ehci-omap is very different with your glue hw driver:
- ehci-omap.c is included into ehci-hcd.c directly, and is
part of ehci-hcd.ko
- ehci-omap.c is part of ehci-hcd, and not a standalone driver, but
musb glue driver is standalone driver(has its own platform_driver
instance implemented)
- if ehci-omap want to be a standalone driver, ehci-hcd has to export
many symbols to ehci-omap, such as,
ehci_urb_enqueue/ehci_urb_dequeue/...
thanks,
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
