Hi Felipe, 2010/12/13 Felipe Balbi <balbi@xxxxxx>: > hi, > > On Mon, Dec 13, 2010 at 09:43:33PM +0800, Ming Lei wrote: >> >> In fact many glue driver used the same default read_fifo/write_fifo, do >> you want to duplicate the code many times in this glue drivers? > > no, look at the code I put: > > /* the below code would be on musb_core.c */ Yes, as said from the comments, musb_read_fifo and musb_write_fifo are defined in musb_hdrc driver(musb_core.c) now. Now some of glue drivers need to access the two symbols to use the default implementation, and other glue drivers have their own .read_fifo/.write_fifo implementations. If the two sybmols are not permitted to be exported from musb_hdrc, the glue drivers which need to access them will have to duplicate this two functions into their own drivers, right? So I think we should allow to export some symbols from musb_hdrc. thanks, -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
