2010/12/13 Felipe Balbi <balbi@xxxxxx>: > On Mon, Dec 13, 2010 at 01:02:16AM +0800, tom.leiming@xxxxxxxxx wrote: >> >> From: Ming Lei <tom.leiming@xxxxxxxxx> >> >> This patch introduces is_inventra_dma helper, so that >> we can remove dependency on CONFIG_USB_INVENTRA_DMA >> in source file of musb core driver in later patches. >> >> Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx> >> --- >> drivers/usb/musb/musb_dma.h | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/usb/musb/musb_dma.h b/drivers/usb/musb/musb_dma.h >> index 70a64a2..b4271b8 100644 >> --- a/drivers/usb/musb/musb_dma.h >> +++ b/drivers/usb/musb/musb_dma.h >> @@ -68,6 +68,12 @@ struct musb_hw_ep; >> #define is_dma_capable() (0) >> #endif >> >> +#ifdef CONFIG_USB_INVENTRA_DMA >> +#define is_inventra_dma() 1 >> +#else >> +#define is_inventra_dma() 0 >> +#endif > > we actually want to get rid of that, all DMA-specific crap should move > to dma layer, MUSB should not care about which DMA it's using. Yes, the helpers above will be removed finally. I think it will be close to the final goal to convert 'ifdef CONFIG_USB_*_DMA' into is_*_dma first. Once the conversion is finished, it will be very easier to remove this helpers and move all dma specific code into its dma controller driver, then musb core(musb_hdrc) will be much more generic than now. thanks, -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
