2010/12/13 Felipe Balbi <balbi@xxxxxx>: > On Mon, Dec 13, 2010 at 01:02:04AM +0800, tom.leiming@xxxxxxxxx wrote: >> >> From: Ming Lei <tom.leiming@xxxxxxxxx> >> >> Each musb hw controller may use different DMA controller, so we >> introduce dma controller related flags and callbacks in glue ops. >> HW glue driver can provide its dma controller information to >> musb core with this flags and callbacks, so we can make musb core >> more generic and avoid to depend on the ugly macro below as far as >> possible: >> >> CONFIG_USB_INVENTRA_DMA >> CONFIG_USB_TUSB_OMAP_DMA >> CONFIG_USB_TI_CPPI_DMA > > DMA controller should be splitted to its own platform_driver also, then Yes, I agree, but we have to remove the dependency on this config option in musb_core.c/musb_gadget.c/musb_host.c first, seems this options are abused now. > you instanciate the correct platform_device on the glue layer. And > that might not be enough either, you could have an omap3/4 device using > sDMA (but you don't have sync lines, so that's not really usable). Before reaching the final goal, we have to remove this options first in source code. -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html