On 12/11/2010 09:32 PM, Pavan Kondeti wrote: > Hi Artem, > > On 12/11/2010 11:42 PM, Artem Leonenko wrote: >> On 12/11/2010 06:14 AM, pkondeti@xxxxxxxxxxxxxx wrote: >> Do you suggest to wait until complete() callback finishes? The earlier >> we will prime EP the faster data will be transmitted. >> > I was saying that (b) is sufficient to fix the problem. I agree that > priming the endpoint before calling complete gives faster data rates. > I was telling (b) and (c) are same. I'm sorry, I misread that >>>> And as a part of the fix to make g_ether (and especially booting with >>>> NFS root) I had >>>> to increase NET_IP_ALIGN to mips32 natural value (4). >>> >>> I am not sure about the fix. But you might want to do this in a separate >>> patch. >>> >> >> Relaxing requirements on alignment will subtly increase memory usage but >> in the same will allow ci13xxx driver + g_ether to support more >> platforms. The ci13xxx driver supports rather big family of IP cores >> so the more we can support the better. >> > >> Can you try to test g_ether with your ci13xxx core with my patches? The >> ci13xxx IP cores have many different flavors/features depending on >> SoC/core instantiation. I wonder whether your core works with >> default alignment or not. >> > Sure. I will test it on monday. But am sure that it will work without > alignment change. Because g_ether is working fine on MSM with another > controller driver (not ci13xxx_udc). Thanks. However it isn't clear to me how can you make an assumption about ci13xxx USB IP core based on features of other USB core. Yes there could be a chance that both cores have same feature. FYI, comment from drivers/usb/gadget/amd5536udc.c file (also search for NET_IP_ALIGN in gadget/Kconfig): > * UDC DMA requires 32-bit aligned buffers so DMA with gadget ether does not > * work without updating NET_IP_ALIGN. Or PIO mode (module param "use_dma=0") > * can be used with gadget ether. You see working g_ether with some UDCs doesn't guarantee that it will work with others. I have a proposal of relaxing alignment requirements and thus increasing the number of supported ci13xxx cores/their instantiations. Don't know if there is something better way to handle that. Any ideas? > Thanks, > Pavan > > -- Cheers, Artem -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
