On 12/08/10 18:23, Wenkai DU wrote:
Hi Richard, Thanks you for your great work! I have just tested your new patch (only hcd part currently). It worked as good as previous release. Certainly we can help running integration testing on PC based platform, as this is the platform our PCI EVB can be used. I have written some code on unloading properly on PCI platform, as well as asynchronously dequeue URB to avoid usbnet deadlock. They seem to be working, but there are still some problems: i.e. issue reboot command while usbnet is loaded then kernel crash. I hope I can send my patch to you somewhere next week. Otherwise, it will be after New Year. Thanks. Best Regards, Wenkai
Hi Wenkai, Thanks for following up. Rather than sending me the patch when you got it, just publish the updated git patch (git squash it onto this one) on the mailing list and cc the interested parties, that way everybody gets to see it, review it, make comments, and rebase to working on the new 'baseline'. - Richard
-----Original Message----- From: Richard Retanubun [mailto:RichardRetanubun@xxxxxxxxxxxxx] Sent: Wednesday, December 08, 2010 11:58 AM To: linux-usb@xxxxxxxxxxxxxxx Cc: fvoegel@xxxxxxxxxxxx; bigeasy@xxxxxxxxxxxxx; djonathan@xxxxxxx; Wenkai DU; Iraj ZARRINNAAL; Richard Retanubun Subject: [PATCH v3] [RFC] USB: ISP1763 driver This patch adds support for STE-ISP1763 USB host and device controller The host-side is based largely on isp1760-hcd and STE pehci driver The device-side and platform parsing code is written mostly from scratch. Co-authored-by: Florian Voegel<fvoegel@xxxxxxxxxxxx> V3: - checkpatch cleanups are applied. - EXPORT_SYMBOL to EXPORT_SYMBOL_GPL - (hdc cleanup) comments from Sebastian are applied. - (udelay) changed to mdelay where applicable. - unused #include<asm/*> removed - isp_debug removed - PCI probe assumes OTG role as host - isp1763_common_init: use res_len for ioremap - fix compiler error about dev.driver_data - stubbed out debug dump code with #ifdef ISP1763_UDC_DEBUG_DUMP - fix misc compiler warning about mixed code and declaration TODO: (that I know of, not comprehensive) - [udc] Sebastian's comments on functional changes to udc (not using the wheel, etc) - [base] Cleanup code on device remove/module unload - [pci] Update PCI to be inline with isp1763-base enhancements. --- Greetings, After cleanups listed above, I figured it is time to post an updated baseline for all who are interested. The patch is not mainline-ready but is a good starting point. [Florian]: I got rid of the compile warnings for udc for using dev.device_data (replaced with [set|get]_gadget__data) still have one remaining for: drivers/usb/isp1763/isp1763_udc.c:1646: warning: ignoring return value of 'device_register', declared with attribute warn_unused_result [Sebastian]: Most of the checkpatch stuff is gone, what is left maybe false-positive (I used checkpatch.pl-testing) The udc cleanups you mentioned will need more work. [David] Sorry if I miss any 2.6.24 specific stuff, you might have an easier time if you patch the 2.6.24 specific stuff on top of this one, that way you can git-rebase your patch to this one whenever there is a new one posted. [Wenkai& ST-Ericsson]: Thanks for joining in the discussion. I am thrilled that there is interest for this driver from the vendor. Do you guys mind being the integration point? (and maintaining future git patches?) my scope of testing for the hdc is PPC centric and my platform is not udc capable, so I'm flying blind there. Would really appreaciate the help in testing& polishing the work to make it mainline-worthy.
-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
