Re: [PATCH v3 20/32] usb: musb: mark ->set_clock deprecated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 07, 2010 at 11:25:02PM +0300, Sergei Shtylyov wrote:
Hello.

Felipe Balbi wrote:

... we will completely drop that need by
moving clock handling to platform glue
layer. Marking as deprecated will allow
us to catch all users easily.

Signed-off-by: Felipe Balbi <balbi@xxxxxx>
[...]

diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
index 6f4e501..0b72b57 100644
--- a/include/linux/usb/musb.h
+++ b/include/linux/usb/musb.h
@@ -119,7 +119,7 @@ struct musb_hdrc_platform_data {
	int		(*set_power)(int state);
	/* Turn device clock on or off */
-	int		(*set_clock)(struct clk *clock, int is_on);
+	int		(*set_clock)(struct clk *clock, int is_on) __deprecated;

  Is it worth it when you're dropping this 2 patches later?

Yes, it really helped finding all users. Besides, I'm trying to do stuff
step by step. So before removing an interface, I mark it __deprecated,
then fix users, then remove it.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux