Hi I will modify it. The update patch will be send soon. -----Original Message----- From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] Sent: Monday, November 29, 2010 8:24 PM To: Chao Xie Cc: 'linux-usb@xxxxxxxxxxxxxxx'; 'gregkh@xxxxxxx'; greg@xxxxxxxxx; 'Alan Stern' Subject: Re: [PATCH 2/2] USB: pxa: Add USB client support for Marvell PXA9xx/PXA168 chips Hello. On 29-11-2010 4:53, Chao Xie wrote: > Hi > How about the patch? Is there anything I should modify? > -----Original Message----- > From: Chao Xie > Sent: Tuesday, November 23, 2010 11:12 AM > To: Alan Stern > Cc: gregkh@xxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; eric.y.miao@xxxxxxxxx > Subject: RE: [PATCH 2/2] USB: pxa: Add USB client support for Marvell PXA9xx/PXA168 chips > Hi > You are right. I have added source code to fix it. Patch is attached. > +static int mv_ep_set_halt_wedge(struct usb_ep *_ep, int halt, int wedge) > +{ [...] > + /* Attempt to halt IN ep will fail if any transfer requests > + * are still queue */ According to Documentation/CodingStyle, the preferred style of the multi-line comments is this: /* * bla * bla */ WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
