Re: [PATCH 2/2] USB: pxa: Add USB client support for Marvell PXA9xx/PXA168 chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 29-11-2010 4:53, Chao Xie wrote:

Hi
How about the patch? Is there anything I should modify?

-----Original Message-----
From: Chao Xie
Sent: Tuesday, November 23, 2010 11:12 AM
To: Alan Stern
Cc: gregkh@xxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; eric.y.miao@xxxxxxxxx
Subject: RE: [PATCH 2/2] USB: pxa: Add USB client support for Marvell PXA9xx/PXA168 chips

Hi
You are right. I have added source code to fix it. Patch is attached.

+static int mv_ep_set_halt_wedge(struct usb_ep *_ep, int halt, int wedge)
+{
[...]
+	/* Attempt to halt IN ep will fail if any transfer requests
+	 * are still queue */

According to Documentation/CodingStyle, the preferred style of the multi-line comments is this:

/*
 * bla
 * bla
 */

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux