Re: [PATCH v2] USB: Add MSM USB Device Controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> implementing specific hooks needed for MSM. I am relying on 
> gadget_is_xxx() macro for MSM specific workarounds.

NEVER DO THAT from inside controller drivers.

(If the code isn't specific to the msm silicon, and works on
other vendors' implementations too, it'd misbehave anyway.

Those calls are for gadget drivers, e.g. to embed knowledge about
controller issues which can't be detected by looking at
what's advertised by the gadget controller device.  Using them isn't
encouraged.


Controller drivers should see what hardware they're talking to by
actually talking to the chip  and detecting any quirks (be they
revision-specific or otherwise).  In some cases platform_data will
be the way to package such information.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux