--- On Tue, 11/9/10, Pavan Kondeti <pkondeti@xxxxxxxxxxxxxx> wrote: > >> Hi Matthieu, > >> > >>> This look like the arc/chipidea/mips ehci otg > core. > >> > >> Yes. It is chipidea core for ARM. > >>> Why can't you reuse the ci13xxx_udc.c driver That basic approach is FAR PREFERABLE. Fix the bugs once, tune once, and so forth, reuse the ULPI support, etc. Work on more platforms, since the silicon IP is reused. You'll end up with more folk who can help maintain the driver too, since the pool of potential helpers won't be limited to those who have/use MSM hardware. Just be sure to cleanly factor the bus (PCI vs MSM-s ARM platform flavor and SoC glues (bus-related). That factoring will likely be the hardest part; but there are examples of similar stuff in Linux today. > ? > >>> Or if ci13xxx_udc.c is too bad, rewrite a new > generic version for this core. > >>> > > Yes, but why not adding this to ci13xxx_udc.c instead > of doing a new driver. > > For example adding platform subsystem is less than 150 > lines of code. > > I agree. > > > > I am not sure doing n drivers for a same hardware is a > good idea. I'm pretty sure it is a BAD idea, myself. Same IP/hardware means only bus/SoC glue really needs to differ (including power and reset management). - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
