On Thu, Nov 25, 2010 at 10:37:16AM -0500, Alan Stern wrote: > > > 2010/11/25 Anton Vorontsov <cbouatmailru@xxxxxxxxx>: > > > > On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote: > > > > [...] > > > >> > ÃÂ#include <linux/module.h> > > > >> > ÃÂ#include <linux/io.h> > > > >> > ÃÂ#include <linux/delay.h> > > > >> > +#include <asm/atomic.h> > > > >> It's not necessary for mach/pm.h already included it, right? > > > > > > > > Technically, it's not necessary. But in Linux we don't rely on > > > > headers including other headers. > > Just saw this. Don't be ridiculous -- this happens all over the place. > People generally aren't aware of it, because it's next to impossible to > verify that all the headers needed by a source file are included > directly. Sure. But that doesn't mean we shouldn't try to keep these things sane enough. I just noticed that the patch introduced atomic_t usage, but didn't include asm/atomic.h, so I corrected this before applying that patch. So I don't see what's the fuss is about. :-) Thanks, -- Anton Vorontsov Email: cbouatmailru@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
