On Thu, Nov 25, 2010 at 09:51:23PM +0800, Lin Mac wrote: > 2010/11/25 Anton Vorontsov <cbouatmailru@xxxxxxxxx>: > > On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote: > > [...] > >> > Â#include <linux/module.h> > >> > Â#include <linux/io.h> > >> > Â#include <linux/delay.h> > >> > +#include <asm/atomic.h> > >> It's not necessary for mach/pm.h already included it, right? > > > > Technically, it's not necessary. But in Linux we don't rely on > > headers including other headers. Think that someday mach/pm.h > > may not include asm/atomic.h, so the build will break. > > > > Thanks, > > Get it. So should I re-submit all 3 patches, or just the last one? Just the last one, thanks! -- Anton Vorontsov Email: cbouatmailru@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html