2010/11/25 Anton Vorontsov <cbouatmailru@xxxxxxxxx>: > On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote: > [...] >> > #include <linux/module.h> >> > #include <linux/io.h> >> > #include <linux/delay.h> >> > +#include <asm/atomic.h> >> It's not necessary for mach/pm.h already included it, right? > > Technically, it's not necessary. But in Linux we don't rely on > headers including other headers. Think that someday mach/pm.h > may not include asm/atomic.h, so the build will break. > > Thanks, Get it. So should I re-submit all 3 patches, or just the last one? >> >> > #include <mach/system.h> >> > #include <mach/cns3xxx.h> >> > #include <mach/pm.h> >> > @@ -117,3 +118,6 @@ int cns3xxx_cpu_clock(void) >> > return cpu; >> > } >> > EXPORT_SYMBOL(cns3xxx_cpu_clock); >> > + >> > +atomic_t usb_pwr_ref = ATOMIC_INIT(0); >> > +EXPORT_SYMBOL(usb_pwr_ref); -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
