On Sat, Nov 20, 2010 at 02:13:23PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 19-11-2010 23:56, Matthew Garrett wrote:
>
> >The AMD SB700 I'm testing with wakes up fine on connection after runtime
> >suspend, but doesn't appear to set the "Port change detect" bit in USBSTS.
> >The change does appear in the individual port register, so try checking
> >the port status as well. It's an infrequent enough operation that the
> >overhead shouldn't be an issue.
>
> >Signed-off-by: Matthew Garrett<mjg@xxxxxxxxxx>
> >---
> > drivers/usb/host/ehci-hub.c | 17 ++++++++++++++++-
> > 1 files changed, 16 insertions(+), 1 deletions(-)
>
> >diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> >index 796ea0c..7653117 100644
> >--- a/drivers/usb/host/ehci-hub.c
> >+++ b/drivers/usb/host/ehci-hub.c
> >@@ -106,12 +106,25 @@ static void ehci_handover_companion_ports(struct ehci_hcd *ehci)
> > ehci->owned_ports = 0;
> > }
> >
> >+static int ehci_port_change(struct ehci_hcd *ehci)
> >+{
> >+ int i = HCS_N_PORTS(ehci->hcs_params);
> >+
> >+ while (i--) {
> >+ if (ehci_readl(ehci,&ehci->regs->port_status[i]) & PORT_CSC)
> >+ return 1;
> >+ }
>
> {} not needed. scripts/checkpatch.pl doesn't complain?
No checkpatch.pl doesn't complain. I also find the braces more readable
when there's multiple indentation levels, or when an if conditional
wraps around. Please stop giving this feedback about braces to
individuals when checkpatch.pl does not complain. You're just adding
overhead to the patch review cycle for the submitter to fix unnecessary
changes.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
