Re: [PATCH] ehci: disable LPM and PPCD for nVidia MCP89 chips

["Brian J. Tarricone" <brian@xxxxxxxxxxxxx>]

On Sun, Nov 21, 2010 at 06:02, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
>
> On 21-11-2010 3:34, Brian J. Tarricone wrote:
>
>> @@ -148,6 +148,18 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
>> Â Â Â Â Â Â Â Â Â Â Â Âif (pdev->revision< Â0xa4)
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âehci->no_selective_suspend = 1;
>> Â Â Â Â Â Â Â Â Â Â Â Âbreak;
>> +
>> + Â Â Â Â Â Â Â /* MCP89 chips on the MacBookAir3,1 give EPROTO when
>> + Â Â Â Â Â Â Â Â* fetching device descriptors unless LPM is disabled.
>> + Â Â Â Â Â Â Â Â* There are also intermittent problems enumerating
>> + Â Â Â Â Â Â Â Â* devices with PPCD enabled.
>> + Â Â Â Â Â Â Â Â*/
>> + Â Â Â Â Â Â Â case 0x0d9d:
>> + Â Â Â Â Â Â Â Â Â Â Â ehci_info(ehci, "disable lpm/ppcd for nvidia
>> mcp89");
>> + Â Â Â Â Â Â Â Â Â Â Â ehci->has_lpm = 0;
>> + Â Â Â Â Â Â Â Â Â Â Â ehci->has_ppcd = 0;
>> + Â Â Â Â Â Â Â Â Â Â Â ehci->command&= ~(CMD_PPCEE);
>
> Â Parens not needed.
>
>> + Â Â Â Â Â Â Â Â Â Â Â break;
>> Â Â Â Â Â Â Â Â}
>> Â Â Â Â Â Â Â Âbreak;
>> Â Â Â Âcase PCI_VENDOR_ID_VIA:

Thanks for the feedback; will send out a new patch shortly.

     -brian
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þë)íèjg¬±¨¶‰šŽŠÝjÿ¾«þG«é¸¢·¦j:+v‰¨Šwèm¶Ÿÿþø®w¥þŠà£¢·hšâÿ†Ù