On Tue, Nov 16, 2010 at 05:06:31PM +0100, Clemens Ladisch wrote: > Greg KH wrote: > > On Tue, Nov 16, 2010 at 09:18:01AM +0100, Clemens Ladisch wrote: > > > Add whitelists so that the OHCI/EHCI PCI drivers can automatically > > > enable MSI for controllers where this is known to work. > > > > Are we going to have to do this for every single device? > > With the whitelist, yes. > > > That's going to be very nasty. > > > > Now I remember why I rejected these patches last time around, this is > > going to be a nightmare. > > The obvious alternative would be a blacklist. With all the unknown > broken-MSI devices out there, this is going to be a nightmare. > > But would you accept patches that make the drivers test, when attaching, > whether the MSI interrupt actually works, and fall back to INTx > otherwise? This would break only for devices that blow up completely > when configured for MSI; I don't know if or how many of those exist. That would be better, but again, is this all really worth it? What benifits will MSI for usb controllers accomplish? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html