Re: [PATCH 072/141] usb: musb: gadget: kill unreachable code in musb_g_rx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 08, 2010 at 01:14:04AM -0600, Balbi, Felipe wrote:
Hi,

On Sun, Nov 07, 2010 at 04:26:47AM -0600, Sergei Shtylyov wrote:
[1] http://marc.info/?l=linux-usb&m=128631363625572&w=2

   I know. But Greg hasn't merged that patch to the Linus' tree and instead
dropped it for unknown reason.

that's odd. I'll re-queue it for next -rc then. Thanks for the note.

Ok, it was dropped because the map/unmap buffer patch was dropped and
this was depending on that patch. Here's the updated patch. I'll send it
in a jiffy.

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index f37b859..36cfd06 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1169,8 +1169,6 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req,
 						: DMA_FROM_DEVICE);
 			request->mapped = 0;
 		}
-	} else if (!req->buf) {
-		return -ENODATA;
 	} else
 		request->mapped = 0;
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux