Re: [PATCH 072/141] usb: musb: gadget: kill unreachable code in musb_g_rx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 22-10-2010 21:56, Greg Kroah-Hartman wrote:

From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

musb_g_rx() always returns if next_request() call yields NULL, so the DBG()
near the function's end can never be invoked. Remove it along with unneeded
'return'; also remove the duplicate 'request' check...

Signed-off-by: Sergei Shtylyov<sshtylyov@xxxxxxxxxxxxx>
Signed-off-by: Felipe Balbi<balbi@xxxxxx>
Signed-off-by: Greg Kroah-Hartman<gregkh@xxxxxxx>

Well, I've just remembered that I've submitted two patches killing unreachable code, and this was patch 2/2 IIRC. Felipe, where did patch 1/2 go? I remember that you've taken it and then posted to the mailing list but what was its fate after that? :-/

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux