On Sat, Oct 23, 2010 at 08:43:28PM +0200, Alon Ziv wrote: > Any module using usb_serial_generic_write (which is already exported) > had better use usb_serial_generic_write_room as well, or be prepared > for failures. As I mentioned elsewhere, this description is a little misleading as any driver can use the generic write_room implementation simply by not overriding it (i.e. leaving the write_room field undefined). There is nothing wrong with exporting it, but it is currently only your other patch that requires that. Could you perhaps just modify the patch description? Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html