On 10/23/2010 06:37 PM, Greg KH wrote: > On Sat, Oct 23, 2010 at 06:20:17PM +0200, Alon Ziv wrote: > >> Any module using usb_serial_generic_write (which is already exported) >> had better use usb_serial_generic_write_room as well. >> > Are you implying that the one driver using this function today is > broken? Care to provide a patch for it as well? > > Well... The one driver using it now is usb_debug, which only supports BREAK signaling. The generic code does not invoke the write_room callback before invoking break_ctl, so there is no way to use this function in usb_serial. At worst, with the current code, usb_serial's break_ctl may become a no-op if another BREAK signal is outstanding--which should not be an issue (assuming regular serial protocol semantics, that is, "BREAK" has indeterminate length). -a -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
